How would u psychologically diagnosed someone who has been angry all their life?

I can't answer and no one else on this forum can answer. You friend needs to talk to a mental health professional if he feels the need for help. There are many possible reasons. Only a trained professional can properly diagnose the problem. And it may take a while.